[SE-4860] feat: backport Celery upgrade - #464
Conversation
9076674 to
3b64203
Compare
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
As I understand this is a transitive dependency pulled by a package which is now pulling lti-consumer-xblock==3.4.4 ref
There was a problem hiding this comment.
@gabor-boros, yeah, I know it's replaced by that entry. I don't know why it's not pinned in base.in, but I also don't know if it's fully compatible with Lilac, as this is a jump from the customv2.10.1 to v3.4.4. For comparison, open-release/lilac.master is using v2.9.1.
If we really want to bump this dependency, then we should make sure that all changes between these versions are compatible. If I remember correctly, v3.0.0 needs this edx-platform change, which wasn't included before Maple. We were trying to maintain backward compatibility before, but this seems to be a breaking change.
There was a problem hiding this comment.
@Agrendalath I had to upgrade pip-tools locally which resulted in a slightly different formatting of comments in the requirements files. The lti-consumer-xblock is not set back to our own version.
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: read through dependency changes
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
See more at openedx#29046 Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
74f18bd to
cd94416
Compare
2 participants
backporting Celery upgrade
See more at openedx#29046
Signed-off-by: Gabor Boros gabor.brs@gmail.com