Skip to content

[BB-6041] Convert compliance warning back to html - #465

Merged
pkulkark merged 1 commit into
opencraft-release/lilac.2-esmefrom
pooja/convert-compliance-warnings-back-to-html
Mar 31, 2022
Merged

[BB-6041] Convert compliance warning back to html#465
pkulkark merged 1 commit into
opencraft-release/lilac.2-esmefrom
pooja/convert-compliance-warnings-back-to-html

Conversation

@pkulkark

Copy link
Copy Markdown
Member

This PR converts the password compliance warning message back to HTML. It was converted to string as part of additional security but that resulted in HTML attributes not being applied while displaying the warning message.

Jira tickets: BB-6041

Screenshots

Before fix:
esme-password-warning

After fix:
esme-stage-warning-after-fix

Testing Instructions:
The fix is already deployed to Esme staging so it can be verified there. The minimum password length has been set to 20.

  1. Register/login with password less than the minimum length requirement.
  2. After login, verify that the warning message is shown correctly.

Reviewers:

@DubeySandeep DubeySandeep left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes in this PR LGTM!

@pkulkark
pkulkark merged commit dcae674 into opencraft-release/lilac.2-esme Mar 31, 2022
@0x29a
0x29a deleted the pooja/convert-compliance-warnings-back-to-html branch September 20, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants