Skip to content

[BB-6123] - Backport Celery upgrade from edx:#29046 - #479

Merged
Agrendalath merged 2 commits into
opencraft-release/maple.3from
navin/backport-celery-maple
Jun 13, 2022
Merged

[BB-6123] - Backport Celery upgrade from edx:#29046#479
Agrendalath merged 2 commits into
opencraft-release/maple.3from
navin/backport-celery-maple

Conversation

@navinkarkera

@navinkarkera navinkarkera commented Jun 8, 2022

Copy link
Copy Markdown
Member

Description

Cherry pick of openedx#29046

Dependencies

Related to open-craft/configuration#198, which cherry picks celery upgrade config to maple branch in opencraft.

Related tickets

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera, I found some inconsistencies between requirement updates between this and the upstream PR. We shouldn't try upgrading other packages unless we're 100% sure that they are compatible with Maple.

Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/edx/base.txt Outdated
Comment thread requirements/constraints.txt Outdated
Comment thread requirements/constraints.txt Outdated
Bump celery and related dependencies to minimum necessary version.

Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
@navinkarkera
navinkarkera force-pushed the navin/backport-celery-maple branch from 64dbec7 to d141215 Compare June 13, 2022 05:15
@navinkarkera

Copy link
Copy Markdown
Member Author

@navinkarkera, I found some inconsistencies between requirement updates between this and the upstream PR. We shouldn't try upgrading other packages unless we're 100% sure that they are compatible with Maple.

@Agrendalath Thanks for catching it. I did not realize that the changes in parents of the cherry pick commits were getting included here. (Learnt something new here. Thanks 😃). Cherry picked commits again and this time made sure that the changes from parent does not get included here.

@navinkarkera
navinkarkera requested a review from Agrendalath June 13, 2022 05:22

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked Celery tasks on the sandbox
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@Agrendalath

Agrendalath commented Jun 13, 2022

Copy link
Copy Markdown
Member

@navinkarkera, yes, cherry-picks can be confusing, because commits are snapshots, not diffs. I can recommend the linked article if you'd like to see how they work internally. This answer is a bit more concise, but it also explains them well.

@Agrendalath
Agrendalath merged commit 1e65dea into opencraft-release/maple.3 Jun 13, 2022
@Agrendalath
Agrendalath deleted the navin/backport-celery-maple branch June 13, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants