[BB-6123] - Backport Celery upgrade from edx:#29046 - #479
Conversation
Agrendalath
left a comment
There was a problem hiding this comment.
@navinkarkera, I found some inconsistencies between requirement updates between this and the upstream PR. We shouldn't try upgrading other packages unless we're 100% sure that they are compatible with Maple.
Bump celery and related dependencies to minimum necessary version. Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
64dbec7 to
d141215
Compare
@Agrendalath Thanks for catching it. I did not realize that the changes in parents of the cherry pick commits were getting included here. (Learnt something new here. Thanks 😃). Cherry picked commits again and this time made sure that the changes from parent does not get included here. |
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: checked Celery tasks on the sandbox
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
@navinkarkera, yes, cherry-picks can be confusing, because commits are snapshots, not diffs. I can recommend the linked article if you'd like to see how they work internally. This answer is a bit more concise, but it also explains them well. |
Description
Cherry pick of openedx#29046
Dependencies
Related to open-craft/configuration#198, which cherry picks celery upgrade config to maple branch in opencraft.
Related tickets