[BB-6438] Check if feature is enabled before calling enterprise api - #485
Merged
pkulkark merged 1 commit intoJul 7, 2022
Merged
Conversation
This fixes the issue of django messages being read before redirecting to dashboard page, due to enterprise api being called even if the feature is disabled.
navinkarkera
approved these changes
Jul 6, 2022
navinkarkera
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this on sandbox
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of django messages being read before redirecting to dashboard page, due to enterprise api being
called even if the feature is disabled. Before maple release, there used to be a waffle switch named
ENABLE_MULTIPLE_USER_ENTERPRISES_FEATUREthat was checked before calling the api. This was deprecated in edx-platform#28057 but was not replaced by any other check for enterprise integration. And so after each login, the enterprise api would be called, which would return 404 but was fetching the django messages (which clears it) and so page banner messages wouldn't show up when the user was redirected to the dashboard page.Supporting Information
JIRA: BB-6438
Testing Instructions
lms.ymlandstudio.ymlfiles, underAUTH_PASSWORD_VALIDATORSupdate the minimum password length requirement to longer than the one you set in the previous step.