(WIP) Content library code for upstream PR - Internal review - #5
Closed
bradenmacdonald wants to merge 36 commits into
Closed
(WIP) Content library code for upstream PR - Internal review#5bradenmacdonald wants to merge 36 commits into
bradenmacdonald wants to merge 36 commits into
Conversation
…onf, and feature flag
Shows the XBlock children stored in the library - just don't press any buttons
Most edit actions in studio now work and create a versioned history.
…riding the branch
…ing a new version of the definition
…e (belongs on subsection/sequential)
Allows modules with 'always_recalculate_grades' to use their children's state when computing their grade via grades.grade()
…ldn't even be an enum anymore?
The new locators help avoid the problematic stripping of branch information.
…ed structures Before, every library also needed draft-branch and published-branch or studio library view would crash
There was a problem hiding this comment.
Same code on line 655 - might make sense to extract method / function.
|
Looks good overall, there are some code style and naming comments though. |
Member
Author
|
@e-kolpakov Thanks for the review and the helpful comments! I'm probably going to ignore the JavaScript style changes for now, since it's just a question of style and I didn't write that code, as mentioned in an earlier comment. |
This was referenced Oct 27, 2014
bradenmacdonald
force-pushed
the
content-library-revisions
branch
from
October 29, 2014 03:47
4fc4022 to
4e841ef
Compare
Member
Author
|
Upstream WIP PR opened at https://github.com/edx/edx-platform/pull/5779 |
e-kolpakov
pushed a commit
that referenced
this pull request
Dec 30, 2015
e-kolpakov
pushed a commit
that referenced
this pull request
Dec 30, 2015
…dback-update-5 Hash Update #5: Diagnostic-Feedback [Bug Fixes]
samuelallan72
pushed a commit
that referenced
this pull request
Jun 7, 2019
SE-1151 Inlines all the discussion underscore templates
DanielVZ96
pushed a commit
that referenced
this pull request
Jan 31, 2024
Allows installation of local versions of NPM packages via module.config.js, allowing frontend devs to test out frontend library changes within devstack. The mounts follow nearly the same pattern that micro-services do, which allows devs to develop local versions of Python packages alongside devstack micro-services. See included ADR #5 for details and rationale. TNL-8407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For internal review before I open the upstream PR.
Things yet to do:
Testing instructions:
paver install_python_prereqsandpaver update_db~/cms.env.jsonand add"ENABLE_CONTENT_LIBRARIES": trueto theFEATURESobject.~/cms.auth.json. Go toMODULESTORE>default>OPTIONS>stores- it should contain two or three entries. Re-order the entries so that the store with"NAME": "split",comes first in thestoreslist. (This makes split the default modulestore for any new courses.)paver devstack studioand go tolocalhost:8001in your browser."library_content"to advanced_modules.library-v1:ProblemX+PR0B. (It's in the URL when you go to the library in studio). Hit Save.localhost:8000. Browse into the course, and you should see that the block is replaced by random blocks from the library. To test the randomization, click the lowest "STAFF DEBUG INFO" link underneath the module, then click "Delete Student State", then refresh the page.