feat: implements SHOW_REGISTRATION_LINKS feature toggle - #528
Merged
viadanna merged 2 commits intoMar 30, 2023
Merged
Conversation
viadanna
marked this pull request as ready for review
March 28, 2023 11:52
Member
|
@viadanna If you click on
|
viadanna
force-pushed
the
viadanna/hide-registration-form-BB-7271
branch
from
March 28, 2023 19:03
182d6e1 to
80b330b
Compare
viadanna
changed the title
viadanna
force-pushed
the
viadanna/hide-registration-form-BB-7271
branch
from
March 29, 2023 19:12
48014c9 to
eb56b8f
Compare
navinkarkera
approved these changes
Mar 30, 2023
navinkarkera
left a comment
navinkarkera
left a comment
Member
There was a problem hiding this comment.
@viadanna Nice. 👍
- I tested this: (Tested it in the sandbox)
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
xitij2000
pushed a commit
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 3025ab5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a
SHOW_REGISTRATION_LINKSconfiguration variable to allow hiding the links to the registration form.Supporting information
BB-7271
Testing instructions
Deadline
ASAP