Skip to content

feat: Add retrieve object_tags REST API - #577

Merged
yusuf-musleh merged 1 commit into
rpenido/fal-3449-taxonomy-view-management-apisfrom
yusuf-musleh/retrieve-object-tags-rest-api
Aug 22, 2023
Merged

feat: Add retrieve object_tags REST API#577
yusuf-musleh merged 1 commit into
rpenido/fal-3449-taxonomy-view-management-apisfrom
yusuf-musleh/retrieve-object-tags-rest-api

Conversation

@yusuf-musleh

@yusuf-musleh yusuf-musleh commented Aug 14, 2023

Copy link
Copy Markdown

Description

This PR exposes the retrieve object tag REST API endpoint from oel_tagging.

Supporting Information

Testing Instructions

  • Run your local devstack,
  • Make have feat: Implement ObjectTag retrieve REST API openedx/openedx-core#68 installed locally, to do that:
    • clone the branch to your DEV_STACK/src
    • uninstall your existing openedx-learning package:
      • make lms-shel
      • pip uninstall openedx-learning
    • install the branch you cloned:
      • make lms-shell
      • cd /edx/src
      • pip install -e openedx-learning
    • Check that the endpoint page works:
      • http://localhost:18000/api/content_tagging/v1/object_tags/

Private Ref: FAL-3452


router = DefaultRouter()
router.register("taxonomies", views.TaxonomyOrgView, basename="taxonomy")
router.register("object_tags", oel_tagging_views.ObjectTagView, basename="object_tag")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO before merge:

Need to merge/tag openedx/openedx-core#68 and bump the installed openedx-learning version before this PR can be merged.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomegranited My branch is actually based off of Romulo's branch openedx#32871 , since he already had the rest_api file structure setup (hence why the changes in my PR are very small) and since I thought his PR might be merging before mine, I kept it that way. If we think we'd want to have them separated, I can close this PR and open a new one against upstream master?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure @yusuf-musleh, I'm happy to merge it to @rpenido 's branch, that makes sense.
We still need openedx/openedx-core#68 to be merged and tagged first, though.

@pomegranited pomegranited left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 -- though we need to bump the openedx-learning version before merging, see note.

@rpenido
rpenido force-pushed the rpenido/fal-3449-taxonomy-view-management-apis branch from 7ee6d0b to 3591589 Compare August 22, 2023 17:23
@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/retrieve-object-tags-rest-api branch from 056955c to 8ab7acd Compare August 22, 2023 19:14
@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/retrieve-object-tags-rest-api branch 3 times, most recently from 36f920c to f0793d7 Compare August 22, 2023 21:58
@yusuf-musleh
yusuf-musleh force-pushed the yusuf-musleh/retrieve-object-tags-rest-api branch from f0793d7 to 25a1f76 Compare August 22, 2023 22:23
@yusuf-musleh
yusuf-musleh merged this pull request into rpenido/fal-3449-taxonomy-view-management-apis Aug 22, 2023
@yusuf-musleh
yusuf-musleh deleted the yusuf-musleh/retrieve-object-tags-rest-api branch August 22, 2023 23:21
rpenido pushed a commit that referenced this pull request Aug 23, 2023
rpenido pushed a commit that referenced this pull request Aug 23, 2023
bradenmacdonald pushed a commit that referenced this pull request Aug 25, 2023
* feat: add taxonomies for org api

* chore: run CI

* feat: Add retrieve object_tags REST API (#577)

* chore: update requirements

---------

Co-authored-by: Yusuf Musleh <yusuf@opencraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants