Skip to content

fix: unhide discussion tab when enabling it - #677

Merged
viadanna merged 4 commits into
opencraft-release/redwood.1from
viadanna/redwood/show-discussion-tab
Sep 4, 2024
Merged

fix: unhide discussion tab when enabling it#677
viadanna merged 4 commits into
opencraft-release/redwood.1from
viadanna/redwood/show-discussion-tab

Conversation

@viadanna

@viadanna viadanna commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Update the is_hidden property in the modulestore to properly store the visibility of the discussions tab.

Supporting information

  • BB-9120

Testing instructions

  1. Create a course in a Palm devstack/sandbox.
  2. Set the discussion tab to hidden.
  3. Export the course.
  4. Import the course in a Redwood devstack/sandbox.
  5. Create a Course Update
  6. Verify the discussion tab disappears in the LMS.
  7. Apply this change to the devstack/sandbox.
  8. Enable the discussions in Studio Pages & Resources.
  9. Create a Course Update.
  10. Verify the discussion tab does not disappear this time.

Deadline

ASAP

@viadanna viadanna self-assigned this Sep 2, 2024
@viadanna viadanna changed the title Draft: fix: unhide discussion tab when enabling it fix: unhide discussion tab when enabling it Sep 3, 2024
xitij2000
xitij2000 requested changes Sep 4, 2024
View reviewed changes
Comment thread openedx/core/djangoapps/discussions/serializers.py Outdated
xitij2000
xitij2000 approved these changes Sep 4, 2024
View reviewed changes

@xitij2000 xitij2000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

  • I tested this: tested by @viadanna
  • I read through the code

@viadanna
viadanna merged commit 11ddc19 into opencraft-release/redwood.1 Sep 4, 2024
@viadanna
viadanna deleted the viadanna/redwood/show-discussion-tab branch September 4, 2024 19:39
viadanna added a commit that referenced this pull request Sep 4, 2024
@viadanna
fix: unhide discussion tab when enabling it (#677)
8c4abae
@viadanna viadanna mentioned this pull request Sep 4, 2024
Merged
viadanna added a commit that referenced this pull request Sep 4, 2024
@viadanna
fix: unhide discussion tab when enabling it (#677)
80e27f6
@viadanna viadanna mentioned this pull request Sep 4, 2024
Closed
Cup0fCoffee pushed a commit that referenced this pull request Mar 2, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
ecaa84f 
(cherry picked from commit 11ddc19)
Cup0fCoffee pushed a commit that referenced this pull request Mar 2, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
36d5889 
(cherry picked from commit 80e27f6)
Cup0fCoffee pushed a commit that referenced this pull request Mar 10, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
15d56f6 
(cherry picked from commit 11ddc19)
Cup0fCoffee pushed a commit that referenced this pull request Mar 10, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
02d95cd 
(cherry picked from commit 80e27f6)
Cup0fCoffee pushed a commit that referenced this pull request Oct 12, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
c168ade 
(cherry picked from commit 11ddc19)
(cherry picked from commit 15d56f6)
Cup0fCoffee pushed a commit that referenced this pull request Oct 12, 2025
@viadanna @Cup0fCoffee
fix: unhide discussion tab when enabling it (#677)
046114b 
(cherry picked from commit 80e27f6)
(cherry picked from commit 02d95cd)
@Cup0fCoffee Cup0fCoffee mentioned this pull request Oct 12, 2025
Merged
viadanna added a commit that referenced this pull request Feb 3, 2026
@viadanna
fix: unhide discussion tab when enabling it (#677)
c3db638 
(cherry picked from commit 11ddc19)
(cherry picked from commit 15d56f6)
viadanna added a commit that referenced this pull request Feb 3, 2026
@viadanna
fix: unhide discussion tab when enabling it (#677)
fd29ce5 
(cherry picked from commit 80e27f6)
(cherry picked from commit 02d95cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xitij2000 xitij2000 xitij2000 approved these changes

Assignees

@viadanna viadanna

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viadanna @xitij2000 @Cup0fCoffee