Skip to content

Updates django-wiki to fix Django requirement issue - #78

Merged
smarnach merged 2 commits into
opencraft-release/ginkgo.1-pearsonfrom
jill/pearson/fix-django-install-requires
Dec 6, 2017
Merged

Updates django-wiki to fix Django requirement issue#78
smarnach merged 2 commits into
opencraft-release/ginkgo.1-pearsonfrom
jill/pearson/fix-django-install-requires

Conversation

@pomegranited

Copy link
Copy Markdown

cf open-craft/django-wiki#1

JIRA tickets: OC-3435

Dependencies: open-craft/django-wiki#1

Merge deadline: ASAP

Testing instructions:

  1. Deploy appserver for Pearson using this branch.
  2. Note that the django-wiki package installs without error.

Author notes and concerns:

  1. Before merging this, merge Fixes Django dependency issue django-wiki#1, and change the django-wiki requirement to be:
    git+https://github.com/open-craft/django-wiki.git@opencraft-release/ginkgo.1#egg=django-wiki==0.0.10
    

Reviewers

  • TBD

@pomegranited
pomegranited force-pushed the jill/pearson/fix-django-install-requires branch from 01ed741 to 9563b63 Compare December 4, 2017 08:51
…ged.

Signed-off-by: Tomasz Gargas <tomasz@opencraft.com>
@tomaszgy

tomaszgy commented Dec 6, 2017

Copy link
Copy Markdown

👍

  • I tested this:
  1. Deployed appserver for Pearson using this branch and saw it work (it's App Server 64).
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Notes: I've updated django-wiki requirement in this PR as suggested by @pomegranited since open-craft/django-wiki#1 has been already merged.

@smarnach, could you please have a look and if all seems good to you we could merge it. Thanks!

@smarnach
smarnach merged commit 39f6c5f into opencraft-release/ginkgo.1-pearson Dec 6, 2017
@pomegranited
pomegranited deleted the jill/pearson/fix-django-install-requires branch December 7, 2017 04:33
pomegranited pushed a commit that referenced this pull request Dec 7, 2017
…l-requires

Updates django-wiki to fix Django requirement issue

(cherry picked from commit 39f6c5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants