[WIP] Use new template inheritance system and add new blocks - #95
Closed
clemente wants to merge 6 commits into
Closed
[WIP] Use new template inheritance system and add new blocks#95clemente wants to merge 6 commits into
clemente wants to merge 6 commits into
Conversation
This allows an overridding template from a theme to inherit from the same corresponding standard template. This is useful when you only want to override one or more named blocks, but otherwise make no modifications to the standard template.
…inheritance system
1 task
clemente
commented
Dec 18, 2017
|
|
||
| <%include file="course_about_sidebar_header.html" /> | ||
|
|
||
| ## FIXME add more blocks to simplify the template |
Author
There was a problem hiding this comment.
After a ${HTML(parent.body())} in the theme template, some blocks started being visible, but not the block-inside-a-block. I'll debug it more.
Author
|
Closed in favor of starting with course_about.html only → see #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks https://github.com/edx/edx-platform/pull/16856/commits to implement a new feature: a template can override only some blocks and use the rest of the content from the parent template (instead of being forced to copy/paste all the parent's content).
And in addition the PRs adds some named blocks that will later be used by the Pearson theme.
WIP because more blocks will come, and because https://github.com/edx/edx-platform/pull/16856/commits will be merged.
JIRA tickets: None
Discussions: None
Dependencies: None
Screenshots: None
Sandbox URL: None
Merge deadline: None
Testing instructions:
Reviewers
Author concerns: None
Settings: None