Problem Builder: Add instance-wide option to hide global feedback and results for Long Answer blocks - #104
Merged
Merged
Conversation
feedback should be shown when student returns to block. The new setting is called "pb_hide_feedback_if_attempts_remain". When set to True, Problem Builder blocks will not show global feedback messages (as long as one or more attempts remain), and will hide results (correct/incorrect icons) for Long Answer blocks.
| ), | ||
| ) | ||
| @ddt.unpack | ||
| def test_persistence(self, options, after_reload_checks): |
Contributor
There was a problem hiding this comment.
DDT stands for data driven testing, I think that names of methods that perform assertions don't qualify as "data" :). I think that splitting this into a helper method (very similar to test_persistence) and four methods that launch it would be beneficial in this case to the overall clarity.
Contributor
|
@itsjeyd It works, I have some minor remarks on code, so conditionally on fixing these/convincing me that status quo is better 👍 . |
- More neutral default for "get_option" - Separate integration tests for checking persistence behavior
itsjeyd
added a commit
that referenced
this pull request
Mar 4, 2016
Problem Builder: Add instance-wide option to hide global feedback and results for Long Answer blocks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an instance-wide option to hide global feedback and results (correct/incorrect) icons for Long Answer blocks in Problem Builder. When this option is enabled (and there are some attempts left), students will still receive global and per-question feedback after providing answers and submitting the containing block, but that feedback will not be visible when they return to the block.
cf. MCKIN-3858
Screenshots: LMS
Default settings:
Feedback hidden:
Screenshots: Apros
Default settings:
Feedback hidden:
Test instructions
Create a subsection with two units and add a Problem Builder block to each one.
Add a long answer, MCQ, Rating, MRQ, and Slider to one of the Problem Builder blocks.
Publish the units.
In LMS/Apros, provide answers to all questions and click "Submit".
Navigate to the other unit, then come back to the first unit. Observe that Problem Builder shows global and per-question feedback for all questions.
In
lms.env.json, enable the new option by modifying theXBLOCK_SETTINGSformentoring:Restart LMS/Apros and reload the page showing the first unit. Observe that Problem Builder does not show global feedback and results for the Long Answer are hidden.