Enable freeform answer submit when feedback is hidden - #110
Merged
Conversation
When the pb_mcq_hide_previous_answer is set to True, MRQs should behave the same way as MCQs behave - previous choices should not be displayed and the checkmarks should be hidden.
mtyaka
changed the title
| @property | ||
| def hide_feedback(self): | ||
| return self.get_option("pb_hide_feedback_if_attempts_remain") and not self.max_attempts_reached | ||
|
|
|
|
||
| // Data may have change, we have to re-validate. | ||
| validateXBlock(); | ||
|
|
Member
There was a problem hiding this comment.
@mtyaka change ⟶ changed. Also, is this still necessary now that answer blocks are handling validation themselves?
Member
Author
There was a problem hiding this comment.
@itsjeyd I fixed the typo, thanks for noticing. This probably isn't necessary for answer blocks anymore (although it shouldn't do any harm), but I believe it still makes sense for other blocks.
Member
|
👍 once newest comment is addressed and build is green. |
When problem builder is configured to hide feedback upon revisiting a question (pb_hide_feedback_if_attempts_remain option is enabled), when the user returns to a problem builder block which contains only a freeform question, the user is not able to click "Submit" without changing the answer text first. This patch fixes that by keeping submit button enabled if pb_hide_feedback_if_attempts_remain is turned on. MCKIN-3890
Member
Author
|
Thanks @itsjeyd! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. MKCIN-3890
Test Instructions
pb_hide_feedback_if_attempts_remainin yourXBLOCK_SETTINGS.This PR also contains a patch that makes MRQ behavior when
pb_mcq_hide_previous_answeroption is enable more consistent with the way MCQs behave. To test:pb_mcq_hide_previous_answerin yourXBLOCK_SETTINGS.