StepBuilder: Fix inconsistent feedback for MCQs - #111
Merged
Conversation
Contributor
|
+1 All good and tested. |
| // handleReview is responsible for setting the "checked" property to true | ||
| // for each choice that the student selected as part of their most recent submission. | ||
| // If it is called after handleSubmit, the check mentioned above will fail, | ||
| // and no feedback will be displayed. |
Contributor
There was a problem hiding this comment.
This is good! Documenting non-obvious behavior of code is something we should do more oftent.
itsjeyd
added a commit
to open-craft/openedx-platform
that referenced
this pull request
Mar 24, 2016
Associated PRs: - open-craft/problem-builder#107 (Fix dashboard report image download) - open-craft/problem-builder#108 (Add instructions for enabling dashboard in studio) - open-craft/problem-builder#109 (Use dashboard image from master branch in tests) - open-craft/problem-builder#111 (StepBuilder: Fix inconsistent feedback for MCQs)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. MCKIN-3907
Test instructions
1and "Extended feedback" toTruefor StepBuilder block.