OC-1441 Detach step elements from DOM or stop playback of closed steps - #112
Closed
jbzdak wants to merge 7 commits into
Closed
OC-1441 Detach step elements from DOM or stop playback of closed steps#112jbzdak wants to merge 7 commits into
jbzdak wants to merge 7 commits into
Conversation
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements
branch
from
March 29, 2016 21:58
006e661 to
3b5a6a9
Compare
added 2 commits
March 30, 2016 15:39
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements
branch
from
March 30, 2016 13:39
2272508 to
b8927bb
Compare
jbzdak
force-pushed
the
jbzdak/oc-1441/detach-step-dom-elements
branch
from
March 30, 2016 14:30
56ec38e to
d356500
Compare
| } | ||
|
|
||
| /** | ||
| * Returns active step) |
Contributor
Author
There was a problem hiding this comment.
There is a dangling ) on the end of comment.
Contributor
Author
|
@itsjeyd All review comments have been addressed (fixes should be visible on both PRs). |
Member
Contributor
Author
|
I'm closing this one, I will post a follow up shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is initial implementation of OC-1441, this stops playback of videos from previous steps.
Course set up
What you need is a course where on a step you have a video, and then you can to the next step (you should still hear the video on that next step --- which is the error).
Essentially you should have a course that looks like this:
Verification instructions
OO.ready(function() { OO.Player.create('xxx', 'yyy_zzz'); });. After you start the video it should work as it was started "normally" so tests are still valid.Testing instructions