Remove "Message (Assessment Review)" from Problem Builder in Studio - #122
Merged
Conversation
pomegranited
changed the title
pomegranited
force-pushed
the
jill/message-assessment-review
branch
2 times, most recently
from
September 28, 2016 05:19
40b325f to
48db943
Compare
itsjeyd
approved these changes
Sep 28, 2016
itsjeyd
left a comment
itsjeyd
left a comment
Member
There was a problem hiding this comment.
@pomegranited This is looking great! I really like the new look of the buttons :)
Just had one nit, but I'm "GitHub-approving" this PR right away because changing a comment won't require additional testing 👍
- I tested this: Works as advertised in PR description.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationAFAIK, review messages aren't documented anywhere, so there is no existing documentation to change as part of this PR. We really should add this information at some point, but that would ideally be part of a general overhaul, which is out of scope here.
| fragment = self.get_author_edit_view_fragment(context) | ||
| fragment.add_content(loader.render_template('templates/html/questionnaire_add_buttons.html', {})) | ||
|
|
||
| # Let the parent block determine whether to display review-related questionnaire options. |
Member
There was a problem hiding this comment.
@pomegranited Nit: "review-related questionnaire options" is a bit vague, maybe change it to "buttons to add review-related child blocks"?
Contributor
Author
There was a problem hiding this comment.
Ah, makes more sense that way.
Addressed in questionnaire.py, and mentoring.py.
…buttons in Problem Builder only if (deprecated) assessment mode is enabled. * Always shows the "on-assessment-review-question" button in Step Builder Questionnaire problems. * Fixes button styles to prevent long button names from overflowing the buttons.
pomegranited
force-pushed
the
jill/message-assessment-review
branch
from
September 29, 2016 00:25
48db943 to
a72c283
Compare
2 tasks
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ability for Studio users to add
Message (Assessment Review)components to Problem Builder units, unless the legacy "assessment mode" is enabled.Studio users may still add
Message (Review)components to Step Builder Questionnaire components, and to legacy "assessment mode" Problem Builder Questionnaire components, but not to new Problem Builder units.Also fixes the style issues these buttons by allowing the buttons to use
width: autoandheight: autoto accommodate varied text lengths.Screenshots:
Message (Assessment Review)removed from Problem Builder:Message (Assessment Review)style fixed in Problem Builder (legacy assessment mode):Message (Assessment Review)removed from Problem Builder Questionnaires:Message (Assessment Review)style fixed in Step Builder and Problem Builder (legacy assessment mode) Questionnaires:Sandbox URL:
Installed 48db943.
Partner information: 3rd party-hosted open edX instance
Testing instructions:
staffuser to the sandbox Studio Problem Builder Demos course.Introduction > Overviewsection, view theProblem Builderunit, and clickViewto see its block components.Message (Assessment Review)button is not present in the list of Components.ViewunderProblem BuilderQuestion 1.Message (Review)button is not present in the list of options.Introduction > Overviewsection, view theProblem Builder Assessment Modeunit, and clickViewto see its block components.Message (Assessment Review)button is present. It is greyed out because this message type has already been added to the unit.ViewunderProblem Builder Assessment ModeQuestion 1.Message (Review)button is present in the list of options. It is greyed out because this message type has already been added to the unit.Message (Review)component.Introduction > Overviewsection, view theStep Builderunit, and clickViewto see its block components.ViewunderStep BuilderQuestion 3.Message (Review)button is present in the list of options. It is greyed out because this message type has already been added to the unit.Message (Review)component.Introduction > Overview, and note that the assessment review functionality is unaffected.Reviewers