Skip to content

Remove migration that extends course_id column - #133

Merged
mtyaka merged 1 commit into
masterfrom
mtyaka/remove-tricky-migration
Nov 24, 2016
Merged

Remove migration that extends course_id column#133
mtyaka merged 1 commit into
masterfrom
mtyaka/remove-tricky-migration

Conversation

@mtyaka

@mtyaka mtyaka commented Nov 24, 2016

Copy link
Copy Markdown
Member

Migration locks the table, which is not desired since the production table on edx.org is quite large.

The course_id field will be extended in a multiple steps instead.

For more info see:

Reviewers:

Migration locks the table, which is not desired since the production
table on edx.org is quite large.

The course_id field will be extended in a multiple steps instead.
For more info see:

- https://github.com/edx/edx-platform/pull/14013
- #131

@itsjeyd itsjeyd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtyaka 👍

  • I tested this: N/A
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A

@mtyaka

mtyaka commented Nov 24, 2016

Copy link
Copy Markdown
Member Author

Thanks @itsjeyd, I'll merge once the build succeeds

@mtyaka
mtyaka merged commit f0cca51 into master Nov 24, 2016
@mtyaka
mtyaka deleted the mtyaka/remove-tricky-migration branch November 24, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants