Override layout of choice label in Apros theme - #141
Merged
Conversation
mtyaka
approved these changes
Feb 10, 2017
Member
|
👍 I tested this in apros - it looks good, just like the screenshots.
|
Member
Author
|
Thanks @mtyaka! I'll follow up with a version bump PR later on today. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to incorporate feedback from QA team (cf. #139 (comment)).
Follows up on #139.
Screenshots: Apros
Problem Builder:
Step Builder:
Screenshots: LMS
Problem Builder:
Step Builder:
Test instructions
Make sure you're using the Apros theme. In
lms.env.json:Add MCQs and MRQs with long choice texts to a Problem Builder block.
Access Problem Builder block in Apros. Observe that layout of choices matches screenshot above.
Repeat previous steps for a Step Builder block.
Switch to LMS theme:
Access Problem Builder and Step Builder blocks in the LMS. Observe that layout of choices matches screenshots above.
Notes
Choice tips will partially cover long choice texts when using the Apros theme. This is not a regression as far as McKinsey is concerned: When switching back to 484131c (parent of merge commit from #125), we get the same behavior. Also, PRs following #125 did not introduce further changes to the layout of choice texts and choice tips.
Reviewers