Avoid count(*) query in management command. - #145
Merged
Conversation
mtyaka
force-pushed
the
mtyaka/copy-course-ids-management-without-count
branch
from
March 5, 2017 12:51
118f931 to
f0ab075
Compare
2 tasks
maxrothman
approved these changes
Mar 20, 2017
|
This looks good assuming you've tested it. |
Count(*) is very slow on large tables.
mtyaka
force-pushed
the
mtyaka/copy-course-ids-management-without-count
branch
from
March 21, 2017 09:07
f0ab075 to
4c2009b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the management command introduced in #143 to avoid a
COUNT(*)query for performance reasons.Testing instructions: Please see #143
Reviewers: