MCKIN-12116 for text provided for label of answer editable - #245
Merged
Conversation
Contributor
Author
|
@msaqib52 please review this |
nasirhjafri
reviewed
Oct 28, 2019
| <div class="xblock-answer" data-completed="{{ self.completed }}"> | ||
| {% if not hide_header %}<h4 class="question-title">{{ self.display_name_with_default }}</h4>{% endif %} | ||
| <label><p>{{ self.question|safe }}</p> | ||
| <label for="label for answer textarea"><p>{{ self.question|safe }}</p> |
Contributor
There was a problem hiding this comment.
Let's add - instead of spaces in id.
nasirhjafri
approved these changes
Oct 28, 2019
Contributor
Author
|
@xitij2000 Please review this pull request and create a release tag. |
Member
|
@musmanmalik Sure, I've created a ticket, and we should review it early next sprint. |
Member
|
@musmanmalik, sorry, haven't noticed that the PR is ready. I'll review this tomorrow. |
Contributor
Author
|
@Agrendalath @xitij2000 any update redarding this? |
Agrendalath
approved these changes
Nov 13, 2019
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: checked that the correct
foris set for thelabel - I read through the code
- I checked for accessibility issues
-
Includes documentation
Member
|
@musmanmalik, thank you for the contribution! I merged the PR and created the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no label for text provided for answer editable. while accessibility testing screen reader was not considering it a valid label while accessibility testing. Now FOR/ID provided for that.