MCKIN-12122: add FOR attribute in mcq and mrq input labels - #246
Merged
Conversation
Member
|
@msaqib52 Sure. We will review this early next sprint. |
Member
|
@msaqib52, sorry for the delay, I didn't notice it's ready for the review. I'll check this tomorrow. |
Agrendalath
approved these changes
Nov 13, 2019
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: checked that the correct
foris set for thelabelof MRQ and MCQ - I read through the code
- I checked for accessibility issues
-
Includes documentation
Member
|
@msaqib52, thank you for the contribution! I merged the PR and created the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The radio buttons and checkboxes for the mcq and mrq are not programmatically associated with its on-screen label and may not be rendered via all assistive technologies correctly. This PR links labels with their respective input fields using for attribute.
@xitij2000 could you review this PR?