Murad/12189 feedback close btn

[murad-hubib]

• Added close button icon in HTML i-e "×" and removed css definition

How to test:

• Select an option from options and a feedback window will be open
• If not, you can click on red/green icon to see it
• The window should display a close button
• There is a change in location of code so apparently it will not effect the visuals

Ticket:
https://edx-wiki.atlassian.net/browse/MCKIN-12189

@xitij2000 Please review, squash and merge

[Agrendalath]

Thank you for the contribution, @murad-hubib. I'll review this today.

[murad-hubib]

Thank you for the contribution, @murad-hubib. I'll review this today.

Thanks for heads up @Agrendalath

[Agrendalath]

@murad-hubib, I tested this on Ironwood devstack and it didn't show up until I manually disabled display: none rule for the div in browser. Should I configure something to see it without such workaround?

This is how it looks on the master version.

This is how it looks after the changes.

Is it supposed to look like this? It's pretty odd to have two "close" buttons there.

[murad-hubib]

@Agrendalath Thanks for pointing out the redundancy of icons. I have removed the icon from html and now i will add it from mcka-theme. Please go ahead.

P.S: Yes the close icon is by default is hidden in xblock.

[Agrendalath]

@murad-hubib, unfortunately I won't have time to review this today. I can do it on Sunday. Please resolve the conflicts in the meantime.

[Agrendalath]

@murad-hubib, please resolve the conflict - it has been changed from div to button in #248.

[Agrendalath]

Also please bump the version in setup.py.

[murad-hubib]

@Agrendalath Resolved conflict and bumped the version

[Agrendalath]

@murad-hubib, thanks! I'll check this tomorrow.

[Agrendalath]

@murad-hubib, okay, so I tested this on my devstack and it looks like the following:

Default theme (in Studio):

Custom theme (with your change CSS for close button checked out):

The icon seems to be missing for me there, but I have an old devstack, so this might be on issue on my side. Could you please confirm that it's working correctly for you?

[Agrendalath]

@murad-hubib, I recompiled the theme with your other PR, but the duplicated icons still appear without it (e.g. when manually enabled in studio). I left two suggestions to make it more straightforward.

[Agrendalath]

👍

• I tested this: tested it on local devstacks with custom theme
• I read through the code
• I checked for accessibility issues
• Includes documentation

[Agrendalath]

@murad-hubib, thanks for explaining the approach. Please bump the version in setup.py. I cannot do this myself, because GitHub is marking setup.py as up-to-date for some reason.

[murad-hubib]

@murad-hubib, thanks for explaining the approach. Please bump the version in setup.py. I cannot do this myself, because GitHub is marking setup.py as up-to-date for some reason.

@Agrendalath Thanks for the understanding. I have bumped the version please go ahead.

[Agrendalath]

@murad-hubib, done. I created the release too. Thank you for the quick turnaround.

[murad-hubib]

Thanks @Agrendalath for prompt response