Skip to content

MCKIN-12203 AF#91-MRQ-Ensure custom controls are keyboard accessible #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgp171188 merged 5 commits into from
Nov 26, 2019
Merged

MCKIN-12203 AF#91-MRQ-Ensure custom controls are keyboard accessible #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73eba16
MCKIN-12203 AF#91-MRQ-Ensure custom controls are keyboard accessible
nasirhjafri Nov 14, 2019
b5da51b
MCKIN-12203 Fixed button outline
nasirhjafri Nov 26, 2019
d2dbb6b
MCKIN-12203 Added margin for choice result
nasirhjafri Nov 26, 2019
9527029
MCKIN-12203 Updated version
nasirhjafri Nov 26, 2019
1bf1663
Merge branch 'master' into MCKIN-12203
nasirhjafri Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions problem_builder/public/css/questionnaire.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@

.mentoring div[data-block-type=pb-mrq] .questionnaire .choice-result {
display: inline-block;
padding: 0;
margin: 0 5px;
background: none;
border: none;
outline: none;
}

.mentoring .questionnaire .choice {
Expand Down
4 changes: 2 additions & 2 deletions problem_builder/templates/html/mrqblock.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ <h4 class="question-title" id="heading_{{ self.html_id }}">{{ self.display_name_
<div class="choices-list">
{% for choice in custom_choices %}
<div class="choice" aria-live="polite" aria-atomic="true">
<div class="choice-result fa icon-2x"
<button class="choice-result fa icon-2x"
id="result_{{ self.html_id }}-{{ forloop.counter }}"
aria-label=""
data-label_correct="{% trans "Correct" %}"
data-label_incorrect="{% trans "Incorrect" %}"></div>
data-label_incorrect="{% trans "Incorrect" %}"></button>
<label class="choice-label"
for="{{ self.html_id }}_{{ forloop.counter }}"
aria-describedby="feedback_{{ self.html_id }}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

# Constants #########################################################

VERSION = '3.3.13'
VERSION = '3.3.14'

# Functions #########################################################

Expand Down