Test + fix for crash when block is deleted after students have used it - #25
Merged
Conversation
bradenmacdonald
force-pushed
the
fix-author-changes
branch
from
April 30, 2015 07:03
d685a22 to
fc5e21a
Compare
Member
|
@bradenmacdonald Please ping me once you've merged the other task and rebased this atop that so that the tests pass. |
bradenmacdonald
force-pushed
the
fix-author-changes
branch
from
April 30, 2015 17:16
fc5e21a to
406e1d1
Compare
Member
Author
|
@Kelketek Tests passing now :) |
bradenmacdonald
force-pushed
the
fix-author-changes
branch
from
April 30, 2015 20:29
406e1d1 to
9162c1e
Compare
Contributor
|
👍 Code looks good. While testing this, I managed to mess up my solutions devstack again, and I don't have time this evening to fix it. Since this PR needs a only a single reviewer anyway, I'll leave the testing to Jonathan. |
Member
|
👍 Works for me! Looks good, too. |
bradenmacdonald
added a commit
that referenced
this pull request
Apr 30, 2015
Test + fix for crash when block is deleted after students have used it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of openedx-unsupported/xblock-mentoring#112