MCKIN-12576 Stopped videos while moving to next step - #254
Merged
Conversation
Contributor
Author
|
@xitij2000 Please review it. |
Member
|
@nasirhjafri Sure. I've put it in for review next sprint. That said I think this approach is too specific and only works for one specific type of video player. I think you should make it more generic so it works with other kinds of video embeds as well. You can do so you can do so by using the underlying HTML video player API. i.e. find all HTML5 video elements and pause them. |
Contributor
Author
|
@xitij2000 Thanks, I've pushed the recommended changes. Please review it in the next sprint. |
xitij2000
reviewed
Dec 16, 2019
xitij2000
left a comment
xitij2000
left a comment
Member
There was a problem hiding this comment.
👍 This is good to merge once the nit has been addressed.
- I tested this: tested on master devstack
- I read through the code
- [na] I checked for accessibility issues
- [na] Includes documentation
Contributor
Author
|
Thanks, @xitij2000 for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCKIN-12576 Stopped videos while moving to the next step
If there is more than one step in assessment and we play a video, the video keeps playing in the background when we move to the next step.