BOM-1146 - #258
Merged
Merged
Conversation
mraarif
approved these changes
Jan 10, 2020
Contributor
Author
|
@jmbowman Please review. |
Contributor
|
Looks good to me; @bradenmacdonald , could we get a review and release from someone on your end? We made a lot of similar fixes in edx-platform for the Python 3 rollout, this just makes sure that Django under Python 2 and 3 both agree that no new migration is needed. |
Member
|
👍 LGTM, thanks! |
Member
|
I've triggered a build; this is good to merge if the build is green. Edit: there's some coverage error but it's unrelated. |
Contributor
|
@bradenmacdonald It looks like the coverage error broke the deployment to PyPI; I'm guessing it has to do with an unpinned dependency on coverage, which recently released version 5 that changed the data file format. |
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For last one month in edx-platform
test_migrations_are_in_synctest was disabled due to some schema changes. Yesterday this test enabled and failing due to some new migrations changes under python3. It was due to the prefixbin few fields.