Skip to content

MCKIN-13390 Arabic/JA translation for review grade - #265

Merged
lgp171188 merged 1 commit into
open-craft:masterfrom
moeez96:MCKIN-13390
Feb 28, 2020
Merged

MCKIN-13390 Arabic/JA translation for review grade#265
lgp171188 merged 1 commit into
open-craft:masterfrom
moeez96:MCKIN-13390

Conversation

@moeez96

@moeez96 moeez96 commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Jira ticket: https://edx-wiki.atlassian.net/browse/MCKIN-13390

Change translation of Review grade:
AR: تصفح الصف
JA: 成績チェッ

@moeez96

moeez96 commented Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

@xitij2000 Please review and tag after merge.

@moeez96 moeez96 changed the title MCKIN-13390 Arabic translation for review grade MCKIN-13390 Arabic/JA translation for review grade Feb 26, 2020
@lgp171188
lgp171188 self-requested a review February 27, 2020 19:03
@lgp171188

Copy link
Copy Markdown
Contributor

@moeez96, I tested this on the Ironwood devstack and was able to verify that the updated translations for the Review grade text show up correctly in Arabic and Japanese. However, when checking the diff of this PR, the .mo files of a few other languages are also changed. Is there a reason why those are changed? If not, can you revert those changes such that only the files related to Arabic and Japanese or changed?

I will approve the PR after I get a clarification from you.

@moeez96

moeez96 commented Feb 28, 2020

Copy link
Copy Markdown
Contributor Author

@lgp171188 The .mo files were generated by the i18n tool's command i18n_tool generate. It seems like some changes that may have been done previously in .po files were not reflected in .mo files. Hence the tool generated files for all languages.
The same may happen if I revert and generate file using i18n_tool again.

@lgp171188

Copy link
Copy Markdown
Contributor

@moeez96, since I have no information about the changes in the files for other languages and hence cannot test or verify them, can you discard those changes from this PR? If required, you can create a separate PR with those discarded changes so that they are not missed.

@moeez96

moeez96 commented Feb 28, 2020

Copy link
Copy Markdown
Contributor Author

@lgp171188 Done, Please review

@lgp171188

Copy link
Copy Markdown
Contributor

@moeez96, 👍

  • I tested this on the Ironwood devstack and verified that updated translations are displayed correctly
  • I read through the code
  • I checked for accessibility issues NA
  • Includes documentation NA

@lgp171188

Copy link
Copy Markdown
Contributor

@moeez96, I have approved the PR. One final question that I have - the تصفح الصف text translates to Browse the class when I checked it on Google Translate. Is this the correct translation?

@moeez96

moeez96 commented Feb 28, 2020

Copy link
Copy Markdown
Contributor Author

@lgp171188 This was a requirement mentioned in the Jira ticket in description. I take the request was made after confirming from native translators.

@moeez96

moeez96 commented Feb 28, 2020

Copy link
Copy Markdown
Contributor Author

@lgp171188 Please merge, and create a release tag. Since I dont have access.

@lgp171188
lgp171188 merged commit 8623a1f into open-craft:master Feb 28, 2020
@lgp171188

Copy link
Copy Markdown
Contributor

@moeez96, I have merged this PR and created a release tag v3.4.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants