Hide "Review final grade" link by default. - #27
Merged
Conversation
The link is only used during extended feedback in assessment mode. It's hidden on page load by JS in all cases, and only shown if the student goes back to a question after using up all attempts, so we can just as well hide it in CSS. This fixes MCKIN-3099.
Member
|
I wasn't able to reproduce the issue but I'm confident this will fix it, and I tested to check for any loss of functionality. 👍 if you rebase and the tests pass. |
smarnach
added a commit
that referenced
this pull request
Apr 30, 2015
Hide "Review final grade" link by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link is only used during extended feedback in assessment mode. It's hidden
on page load by JS in all cases, and only shown if the student goes back to a
question after using up all attempts, so we can just as well hide it in CSS.
This fixes MCKIN-3099.
@bradenmacdonald I can't reproduce the issue on my local Apros installation, neither with Firefox nor with Chrome. I can reproduce it using the link and credentials in MCKIN-3099, though, so it's probably dependent on the timing of AJAX responses, or something along these lines. Could you please try whether you are able to reproduce the issue, and whether this patch fixes it? I'm rather confident it does.
The issue occurs when moving forward (or back) to a unit with a mentoring question in standard mode using the blue Apros navigation arrows -- see the video in MCKIN-3099.