MCKIN-15673 Japanese translations corrections - #274
Conversation
New Stuff
Marge PR open-craft#271: japanese translation update
viadanna
left a comment
viadanna
left a comment
There was a problem hiding this comment.
@musmanmalik I've left a couple comments, I'll now test this.
| else: | ||
| new_lang = language | ||
| return self.resource_string('public/js/translations/{lang}/textjs.js'.format( | ||
| lang=utils.translation.get_language(), |
There was a problem hiding this comment.
Didn't this work for Japanese? Why was it removed in favor of a manual approach?
There was a problem hiding this comment.
Here we are receiving language code like ja-jp, de-DE while we have directories ja_JP ,de_DE , etc. If we don't do like this the default en is returning. That is we need to do this.
There was a problem hiding this comment.
So for four character language code we need to change last 3 characters. - to _ last two characters to upper case e.g. jp to JP.
There was a problem hiding this comment.
Might be good to have a comment here to make that more clear.
There was a problem hiding this comment.
@bradenmacdonald Thank you for highlighting. I have added a comment. Please proceed.
Thanks
| "\u7d50\u679c\u3092<%= creation_time %> (<%= seconds %> \u79d2) \u3067\u53d6\u5f97\u3057\u307e\u3057\u305f\u3002" | ||
| ], | ||
| "The report is currently being generated\u2026": "\u73fe\u5728\u30ec\u30dd\u30fc\u30c8\u3092\u4f5c\u6210\u4e2d\u3067\u3059\u2026" | ||
| "The report is currently being generated\u2026": "\u73fe\u5728\u30ec\u30dd\u30fc\u30c8\u3092\u4f5c\u6210\u4e2d\u3067\u3059\u2026", |
There was a problem hiding this comment.
While I can test this and review it works, I cannot attest the translation.
There was a problem hiding this comment.
We got these translations from trusted translator.
| "You have used {num_used} of 1 submission.": [ | ||
| "上限{max_attempts}回のうち {num_used} 回提出しました。", | ||
| "上限1回のうち {num_used} 回提出しました。" | ||
| ], |
There was a problem hiding this comment.
Not sure I understand correctly, but I think you have plural first, when it's expected to be second, e.g.
There was a problem hiding this comment.
@viadanna have you tested this one? I have tested this and working fine as written in this pr.
There was a problem hiding this comment.
This was the result for a setup with 3 attempts.
Seems it's just different for JP.
There was a problem hiding this comment.
This is result is after first attempt out of three
There was a problem hiding this comment.
"You have used 1 of 3 submissions" needs to translate to "上限3回のうち１回提出しました。"
Translator has given us the same
|
@bradenmacdonald @viadanna Please review this. A test is failing which seems not related to the changes in this pr. This may be a flaky test case. Rest if all is good kindly merge this and create a release tag. Thanks |
|
Alright, merged and tagged, @musmanmalik |
3 participants
Japanese translations corrections