SE-1917 Replace hacky sleeps with webdriver waits - #275
Merged
Conversation
pomegranited
approved these changes
Apr 21, 2020
pomegranited
left a comment
Contributor
There was a problem hiding this comment.
👍 LGTM @swalladge !
- I tested this by ensuring the automated tests had passed consistently.
- I read through the code changes, and checked all the places in the tests where
sleepis still invoked, to ensure there were no better options available. -
I checked for accessibility issuestest changes only - Includes documentation -- adds code comments where sleep was still required.
-
I made sure any change in configuration variables is reflected in the correspondingN/A
client'sconfiguration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests don't appear to be flaky on my machine with python 3 any more, but this at least removes the hacky manual sleeps where possible. Instead it relies on webdriver waiting for changes to happen (element to exist, become visible, etc.). This will be faster and more reliable.
Test instructions:
Reviewer: