MCKIN-15914 Tips should not show if empty - #276
Merged
Conversation
Contributor
Author
|
@xitij2000 Please review, merge and tag. |
Member
|
@moeez96 Problem Builder master is now at v4, however v4 is not compatible with solutions currently. So please create a PR for the problem-builder-v3 branch as well. Till solutions is compatible with v4 every PR to v3 should come with a master PR as well so that they are in sync. |
Contributor
Author
|
@xitij2000 Base for this PR has been set to problem-builder-v3 |
Contributor
|
@xitij2000 @moeez96 Thanks for the PR, I have checked it on both the devstacks(v3 and master) LGTM 👍 |
Contributor
Author
|
@rusrushal13 @xitij2000 Please merge, and tag since I dont have access. |
xitij2000
approved these changes
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://edx-wiki.atlassian.net/browse/MCKIN-15914
Issue:
Even if tips are empty for a choice in an MRQ, html is added to
tip_choice_group.htmlanyway. This shows an empty tip box to user which is undesired UX.Solution:
Do not add html in tips if not tips exist for condition here to hold true.