[BB-2320] Fix the CI checks after merge - #279
Merged
lgp171188 merged 1 commit intoApr 29, 2020
Merged
Conversation
This will fix the failing quality checks and also the integration tests.
rusrushal13
force-pushed
the
rushal/BB-2320-problem-builder-v4-merge-fix-CI-checks
branch
from
April 29, 2020 10:08
44ba3eb to
f178c68
Compare
Closed
lgp171188
self-requested a review
April 29, 2020 10:10
Contributor
|
@rusrushal13, the changes in this PR look good to me. Let's wait for the CI checks to pass. |
lgp171188
approved these changes
Apr 29, 2020
lgp171188
left a comment
lgp171188
left a comment
Contributor
There was a problem hiding this comment.
👍
- I verified that this PR fixes the failing CI checks and all the changes from the
problem-builder-v4branch are now intact in themasterbranch. - I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
lgp171188
deleted the
rushal/BB-2320-problem-builder-v4-merge-fix-CI-checks
branch
April 29, 2020 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI checks which started failing after merging the
problem-builder-v4branch to themasterbranch.Test instructions:
Reviewer:
Issue: BB-2320