MCKIN-19683: fix translations issues - #288
Conversation
|
@msaqib52 Please make a PR against master as well. |
|
@xitij2000 i will create PR against master once this PR is reviewed, so that PR against master has reviewed and updated changes. Also could you rerun the |
taniwha
left a comment
taniwha
left a comment
There was a problem hiding this comment.
👍
- I tested this: (describe what you tested)
- I read through the code
- [ ] I checked for accessibility issues
- [ ] Includes documentation
- [ ] I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
|
@msaqib52 The patch looks good to me, but the failed test case is a bit of a concern, so I haven't merged yet. If it proves to be a non-issue, I will merge. |
|
In the end, it passed. |
|
@msaqib52 Please create a master PR as well now that this is merged. |
* fix translations issues * korean translation update
|
@xitij2000 @taniwha have created this PR against master. Could you also create the release tag for v3 merge. |
|
@msaqib52 sorry, I had... sort of. I think I hit the wrong button when I was finished and failed to notice. Sorry. Fixed now. |
|
@taniwha Thank you. |
3 participants
Some of the strings were not getting translated due to unavailability of translation service in student view. For some strings plural forms were not working due to incorrect translations format, This PR fixes these issues.
@xitij2000 can you review this?