-
Notifications
You must be signed in to change notification settings - Fork 59
Instructor Tool XBlock - Polish (OC-751) #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b74d5d1
Rename "Data Export" block to "Student Answers Dashboard" (user-facing
itsjeyd 28cebfd
Rename files that implement data export to match new name of XBlock.
itsjeyd caf0714
Update Student Answers Dashboard key for advanced modules.
itsjeyd a199b82
Display data to be exported in Student Answers Dashboard XBlock.
itsjeyd 777a9a4
Make contents of CSV file match results displayed on page.
itsjeyd b9ebeee
Empty result table before adding new results.
itsjeyd 3e4edf4
Hide results table if no data is available.
itsjeyd e0f62ff
Allow instructors to filter answers by content.
itsjeyd f463897
Rework UI of Student Answers Dashboard.
itsjeyd 96496aa
Update and extend integration tests for problem-builder.
itsjeyd d1f2ef6
Paginate export results on the client.
itsjeyd 56dc273
Make existing problem-builder tests pass.
itsjeyd 6ee520a
Extend existing problem-builder tests.
itsjeyd c7fd48a
Add integration tests for pagination.
itsjeyd f1e8f6a
Include full MIT license for third-party libraries backbone.paginator,
itsjeyd b8050f2
Fix pep8 violations.
itsjeyd 9fe9f34
Fix pylint violations.
itsjeyd 01e30ce
Address review comments.
itsjeyd f57db13
Fix "ImportError: 'module' object has no attribute 'DataExportBlock'".
itsjeyd dae27b3
Cache answer choices for MCQs.
itsjeyd 90e0b0e
Rename "Student Answers Dashboard" to "Instructor Tool".
itsjeyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| ------------------------------------------------------------------------------ | ||
| This license applies to the following third-party libraries included | ||
| in this repository: | ||
|
|
||
| - backbone.paginator | ||
| - Backbone.js | ||
| - Underscore.js | ||
| ------------------------------------------------------------------------------ | ||
|
|
||
| The MIT License (MIT) | ||
|
|
||
| Copyright (c) [year] [fullname] | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| .data-export-options, .data-export-results, .data-export-status { | ||
| margin-top: 2em; | ||
| } | ||
| .data-export-options, .data-export-results table { | ||
| border: 2px solid #999; | ||
| } | ||
| .data-export-options, .data-export-results thead { | ||
| background-color: #ddd; | ||
| } | ||
| .data-export-options { | ||
| display: table; | ||
| padding: 1em; | ||
| } | ||
| .data-export-header, .data-export-row { | ||
| display: table-row; | ||
| } | ||
| .data-export-header h3, .data-export-results thead { | ||
| font-weight: bold; | ||
| } | ||
| .data-export-header h3 { | ||
| margin-top: 0px; | ||
| margin-bottom: 10px; | ||
| } | ||
| .data-export-field-container, .data-export-options .data-export-actions { | ||
| display: table-cell; | ||
| padding-left: 1em; | ||
| } | ||
| .data-export-field { | ||
| margin-top: .5em; | ||
| margin-bottom: .5em; | ||
| } | ||
| .data-export-field label span { | ||
| padding-right: .5em; | ||
| vertical-align: middle; | ||
| } | ||
| .data-export-field input, .data-export-field select { | ||
| max-width: 60%; | ||
| float: right; | ||
| } | ||
| .data-export-results, .data-export-download, .data-export-cancel, .data-export-delete { | ||
| display: none; | ||
| } | ||
| .data-export-results table { | ||
| width: 100%; | ||
| margin-top: 1em; | ||
| } | ||
| .data-export-results thead { | ||
| border-bottom: 2px solid #999; | ||
| } | ||
| .data-export-results td { | ||
| border-left: 1px solid #999; | ||
| padding: 5px; | ||
| } | ||
| .data-export-results tr:nth-child(odd) { | ||
| background-color: #eee; | ||
| } | ||
| .data-export-info p { | ||
| font-size: 75%; | ||
| } | ||
| .data-export-status { | ||
| margin-bottom: 1em; | ||
| } | ||
| .data-export-status i { | ||
| font-size: 3em; | ||
| } | ||
| .data-export-actions { | ||
| text-align: right; | ||
| } |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjeyd Is it necessary to include these? Backbone and Underscore should both be available in Studio and the LMS:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenmacdonald It's not necessary to include Backbone and Underscore when running problem-builder inside LMS/Studio, I just checked. However, tests fail horribly without them. Is there a way to conditionally include them, i.e., load them iff problem-builder is running as a standalone XBlock?