Visual improvements to Table block. - #49
Conversation
|
@bradenmacdonald And you should probably verify these as well, come to think of it. |
There was a problem hiding this comment.
Did you intend to use this event parameter, or are you just adding it for consistency?
|
Looks good! 👍 if you get tests passing. Failures look unrelated so maybe just run the builds again. |
|
@bradenmacdonald I've rerun the tests a few times. Each time the failure is somewhere else but not related to the current changes, usually appearing to be something with upstream libraries, like getting more than one block or a transaction error. I can't seem to restart it anymore. Since all the tests have passed individually, I'm going to go ahead and merge so @mtyaka can complete his end of things. |
Visual improvements to Table block.
|
@Kelketek Can you please create a JIRA ticket then about the flaky tests? |
|
@bradenmacdonald A ticket has been added to the backlog. |

@antoviaque Hopefully these should address your notes.
Note, instead of making an extra download button, I placed the link where you suggested. Adding a download button would have prompted a lot more work in terms of alignment of the pop-ups and notifications, and I felt that it would be better to just place it down below.