Add an extra selector to fix CSS rule ambiguity - #53
Merged
Conversation
Member
Author
|
@mtyaka Since you're in the right timezone, you'll need this to deploy, and have you experience with this part of problem builder, can you please review this? |
Member
|
👍 |
mtyaka
added a commit
that referenced
this pull request
Jul 28, 2015
Add an extra selector to fix CSS rule ambiguity
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: OC-839
On the Harvard GSE instance, Problem Builder's LMS theme was not rendering correctly. The issue turned out to be that some of the theme's CSS rules had the same specificity as the "unthemed" rules, so that which one would be used was ambiguous.
Screenshot showing desired interpretation and valid but wrong interpretation.
Fix was to add an extra CSS selector to each of the rules in question.