Fix: Translate links in table column headers - #59
Conversation
correctly in the LMS.
d4496e7 to
b232a70
Compare
|
👍 Works for me, code looks fine. |
|
Can we add a test for this? |
|
@antoviaque The code conditionally uses functionality from the LMS runtime to translate |
|
@itsjeyd Could you mock the |
in column headers.
|
@antoviaque Thanks for the suggestions, mocking @Kelketek Please have another look. |
|
👍 if the tests pass. I've retriggered the failing build since it seems to be one of those random flaky ones. |
Fix: Translate links in table column headers
In the LMS, links of the form
/jump_to_id/<unit identifier>are currently not translated/expanded correctly when they are part of a table column header. For example,correctly expands to
when added to an HTML block. But when added to the column header of an Answer Recap table the expanded URL ends up missing information about the parent course (leading to an invalid link):
This PR adds code that makes sure links to course units that are part of table column headers are expanded correctly inside the LMS.
Testing
course-v1:HGSE+IOCEX+2015_T1course from the Harvard instance and import it into your local devstack.