Skip to content

Making question checkmark display question-level feedback + tests - #60

Merged
e-kolpakov merged 1 commit into
masterfrom
extended-feedback-question-message-fix
Sep 7, 2015
Merged

Making question checkmark display question-level feedback + tests#60
e-kolpakov merged 1 commit into
masterfrom
extended-feedback-question-message-fix

Conversation

@e-kolpakov

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround includes clicking on things, and every click outside the feedback area closes it. But one of the aspects of the test below is to check if the feedback is shown when user opens the question for review. Hence, the workaround was removed. It worked in my dev environment, so if it works just fine on CI it might mean the workaround was not needed here at all.

@Kelketek

Kelketek commented Sep 4, 2015

Copy link
Copy Markdown
Member

👍

e-kolpakov added a commit that referenced this pull request Sep 7, 2015
…sage-fix

Making question checkmark display question-level feedback + tests
@e-kolpakov
e-kolpakov merged commit 947c75f into master Sep 7, 2015
@e-kolpakov
e-kolpakov deleted the extended-feedback-question-message-fix branch September 7, 2015 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants