Fixed appearance of step links in extended feedback - #69
Merged
Conversation
Member
There was a problem hiding this comment.
@bradenmacdonald The code in this line is quite dense; could you break the assignments up into multiple lines?
Member
|
@bradenmacdonald Looks good! I tested both LMS and Apros, and it works well. Just had two small comments/questions about the code, 👍 otherwise. |
Member
Author
|
Thanks @itsjeyd ! |
bradenmacdonald
force-pushed
the
ext-feedback-links-polish-oc-986
branch
from
October 10, 2015 04:34
361cba9 to
457ee18
Compare
bradenmacdonald
added a commit
that referenced
this pull request
Oct 10, 2015
Fixed appearance of step links in extended feedback
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OC-986
This fixes two issues with the appearance of the question links in the "review" step in Step Builder:
Before:
After (Apros):
After (LMS):
