Allow Videos and images to be added to Mentoring Step Block. - #73
Merged
Conversation
Member
There was a problem hiding this comment.
@Kelketek Now that this method does more than simply returns a static list, do you think it would make sense to add a unit test for it? I'm not sure how easy it is, but I'm guessing you could fake the modules that contain VideoDescriptor and ImageModal in tests.
Member
|
@Kelketek I'm wondering whether we could add a test for the |
Kelketek
force-pushed
the
nested-steps
branch
from
October 16, 2015 15:19
169000d to
2d777ef
Compare
Member
Author
|
@mtyaka I was able to get tests in. Could you take a look at the test code? |
Member
|
@Kelketek Great, thanks! 👍 One of the travis checks failed, but the failure looks weird, I"m guessing it was just a temporary issue? |
Member
Author
|
@mtyaka Yeah. Most likely. I'll force a rerun and merge when it passes. |
Kelketek
force-pushed
the
nested-steps
branch
from
October 19, 2015 14:36
2d777ef to
ad9c90d
Compare
Kelketek
force-pushed
the
nested-steps
branch
from
October 19, 2015 16:41
b3ea5ea to
c131a90
Compare
Kelketek
added a commit
that referenced
this pull request
Oct 19, 2015
Allow Videos and images to be added to Mentoring Step Block.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mtyaka
Testing instructions: