Skip to content

Fix invalid appearance in Apros due to their box-sizing global - #8

Merged
bradenmacdonald merged 3 commits into
developfrom
apros-fix
Apr 15, 2015
Merged

Fix invalid appearance in Apros due to their box-sizing global#8
bradenmacdonald merged 3 commits into
developfrom
apros-fix

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Member

Apros CSS has the rule *, *:before, *:after { box-sizing: border-box; }, which (not surprisingly) messes up the layout of our tip popups.

Before screenshot:
apros-before

After screenshot:
apros-after

Testing instructions:

  • Use a birch rebase branch of the solutions fork of edx-platform. The only one that's currently working for me is braden/birch-rebase-testing

  • Add the following to ~/lms.env.json:

      "XBLOCK_SETTINGS": {
          "mentoring": {
              "theme": {
                  "package": "problem_builder",
                  "locations": ["public/themes/apros.css"]
              }
          }
      }
  • Open Apros and look at an MCQ/MRQ with tips.

@e-kolpakov

Copy link
Copy Markdown
Contributor

@bradenmacdonald 👍 - not verified for the same reason I gave at jquery-xblock PR

@antoviaque

Copy link
Copy Markdown
Member

@bradenmacdonald Thanks for fixing this!

The screenshots made me notice that the checkmarks/exclamation marks aren't well aligned - if you look closely their center is below the center of the corresponding line. (It's also worth checking with answers that have multiple lines btw, or contain HTML, as we've had issues with those in the past)

@Kelketek

Kelketek commented Apr 9, 2015

Copy link
Copy Markdown
Member

@bradenmacdonald I would have given you a +1, but since @antoviaque appears to have added a bit here, so I'm going to hold off until that's all groovy.

@bradenmacdonald

Copy link
Copy Markdown
Member Author

OK, should be fixed in latest commit. How's this?

Apros screenshot:
screen shot 2015-04-10 at 12 49 38 am

Studio screenshot:
screen shot 2015-04-10 at 12 54 09 am

@antoviaque

Copy link
Copy Markdown
Member

@bradenmacdonald That looks great : ) Thanks for the fix!

@Kelketek

Copy link
Copy Markdown
Member

@bradenmacdonald I'm going to work on getting a rebased solutions devstack up and running. However I'd like you to see if you can fix the flaky test that failed the push build on Travis in the meantime.

@bradenmacdonald

Copy link
Copy Markdown
Member Author

@Kelketek Sure thing. I have now fixed the flaky test in this PR (I hope). Turns out I was using a random number that was not sufficiently random, resulting in conflicting ids for label/checkbox pairs.

@e-kolpakov

Copy link
Copy Markdown
Contributor

@bradenmacdonald verified, this PR looks good, but it missed the fixes you made in #9. Conditional 👍 if #9 is to be added later.

@bradenmacdonald

Copy link
Copy Markdown
Member Author

Thanks @e-kolpakov. Yes, Once #9 is approved and merged I will cherry-pick all of its fixes onto master as well.

@Kelketek

Copy link
Copy Markdown
Member

LGTM 👍

@bradenmacdonald
bradenmacdonald merged this pull request into develop Apr 15, 2015
@bradenmacdonald
bradenmacdonald deleted the apros-fix branch April 15, 2015 20:42
bradenmacdonald added a commit that referenced this pull request Apr 16, 2015
Fix invalid appearance in Apros due to their box-sizing global
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants