Skip to content

Add instructional message to step blocks. - #84

Merged
Kelketek merged 1 commit into
masterfrom
instruction-message
Oct 26, 2015
Merged

Add instructional message to step blocks.#84
Kelketek merged 1 commit into
masterfrom
instruction-message

Conversation

@Kelketek

Copy link
Copy Markdown
Member

To test:

  1. Create a step builder block.
  2. Add a step to the block.
  3. Edit the block. Fill in the message section
  4. Add a problem to the block.
  5. Save, answer the problem, submit, see new popup thingy. Click anywhere and it should dismiss.

@Kelketek

Copy link
Copy Markdown
Member Author

@itsjeyd

@itsjeyd

itsjeyd commented Oct 23, 2015

Copy link
Copy Markdown
Member

@Kelketek I tested and the feature is working well overall (love the box-shadow :)).

There are a couple of minor glitches:

  1. The fact that the background of the message is transparent can make some areas of it a little harder to read; this mostly affects longer messages. Example screenshots:

    message-readability-1
    message-readability-2

  2. If I submit and then click "Next step" without explicitly dismissing the message, the message is visible when I restart Step Builder via "Try again".

Code looks good, just had a couple of minor comments.

Comment thread problem_builder/public/js/step.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek This is missing a semicolon.

@Kelketek
Kelketek force-pushed the instruction-message branch from 759f732 to e64b325 Compare October 24, 2015 00:03
@Kelketek

Copy link
Copy Markdown
Member Author

@itsjeyd Ready for another look.

@itsjeyd

itsjeyd commented Oct 26, 2015

Copy link
Copy Markdown
Member

@Kelketek 👍 once you fix the failing build (it's just a leftover blank line at the end of test_step_builder.py).

@Kelketek
Kelketek force-pushed the instruction-message branch from e64b325 to 17aeea3 Compare October 26, 2015 12:55
Kelketek added a commit that referenced this pull request Oct 26, 2015
Add instructional message to step blocks.
@Kelketek
Kelketek merged commit 127c50d into master Oct 26, 2015
@Kelketek
Kelketek deleted the instruction-message branch October 26, 2015 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants