Skip to content

Bump version number. - #97

Merged
Kelketek merged 1 commit into
edx-releasefrom
bump_version
Feb 4, 2016
Merged

Bump version number.#97
Kelketek merged 1 commit into
edx-releasefrom
bump_version

Conversation

@Kelketek

@Kelketek Kelketek commented Feb 4, 2016

Copy link
Copy Markdown
Member

@bradenmacdonald Who would we need to review this? It's needed for https://github.com/edx/edx-platform/pull/11312 All it does is bump the version number.

@bradenmacdonald

Copy link
Copy Markdown
Member

👍
It's ok that CircleCI failed since CircleCI is not enabled on this branch.
We should also get a plus 1 from any one of the reviewers on your other PR, then go ahead and merge this.

BTW In future, please don't create the git tag (v2.0.1) until after this version bump PR has merged. Then once it has merged, go ahead and tag the merge commit then push the tag. The main reason for this is that tags shouldn't be changed once published (similar to the reason we don't do force pushes to master), and you want to leave yourself some room to fix things in case the version bump PR has an issue.

@Kelketek

Kelketek commented Feb 4, 2016

Copy link
Copy Markdown
Member Author

@nedbat FYI, version update PR to address the tagging issue for the problem builder hash bump.

@nedbat

nedbat commented Feb 4, 2016

Copy link
Copy Markdown

I know this is a pain, but TBH I would not count on the moved tag at all. It's safer to go to 2.0.2.

@Kelketek

Kelketek commented Feb 4, 2016

Copy link
Copy Markdown
Member Author

@nedbat Very well. I'll update the version again. One moment...

@Kelketek

Kelketek commented Feb 4, 2016

Copy link
Copy Markdown
Member Author

@nedbat Updated.

@nedbat

nedbat commented Feb 4, 2016

Copy link
Copy Markdown

👍

Kelketek added a commit that referenced this pull request Feb 4, 2016
@Kelketek
Kelketek merged commit a4e1e42 into edx-release Feb 4, 2016
@Kelketek
Kelketek deleted the bump_version branch February 4, 2016 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants