chore: adapt telemetry setup error handling#1315
Merged
toddbaert merged 5 commits intoopen-feature:mainfrom May 27, 2024
Merged
chore: adapt telemetry setup error handling#1315toddbaert merged 5 commits intoopen-feature:mainfrom
toddbaert merged 5 commits intoopen-feature:mainfrom
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
==========================================
+ Coverage 73.69% 78.71% +5.02%
==========================================
Files 32 36 +4
Lines 3140 2824 -316
==========================================
- Hits 2314 2223 -91
+ Misses 717 466 -251
- Partials 109 135 +26 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
the
size:L
thisthat
approved these changes
May 22, 2024
Kavindu-Dodan
approved these changes
May 23, 2024
Contributor
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Nice work, I left few comments which once resolved I can approve this :)
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kavindu-Dodan
force-pushed
the
feat/1194/otel-error-handling
branch
from
2745606 to
155bf59
Compare
toddbaert
approved these changes
May 27, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.10.3</summary> ## [0.10.3](flagd/v0.10.2...flagd/v0.10.3) (2024-06-06) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) * fix unit tests and ensure their execution ([#1316](#1316)) ([25041c0](25041c0)) </details> <details><summary>core: 0.9.3</summary> ## [0.9.3](core/v0.9.2...core/v0.9.3) (2024-06-06) ### 🐛 Bug Fixes * fixes store merge when selector is used ([#1322](#1322)) ([ed5025d](ed5025d)) ### 🧹 Chore * adapt telemetry setup error handling ([#1315](#1315)) ([20bcb78](20bcb78)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194
This PR adapts the service setup to not fail when encountering an error in the telemetry setup.