fix: run htmltest directly in CI to avoid Docker Hub rate limits#1358
Closed
jonathannorris wants to merge 1 commit intomainfrom
Closed
fix: run htmltest directly in CI to avoid Docker Hub rate limits#1358jonathannorris wants to merge 1 commit intomainfrom
jonathannorris wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
The `make test` target depends on `build`, which pulls `node:24-bullseye` from Docker Hub via Docker. In CI, the build is already produced by the native `yarn build` step, so the Docker pull is redundant and intermittently hits Docker Hub rate limits in the merge queue. Run the `htmltest` container directly instead, using the `build/` directory produced by the prior step. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
jonathannorris
force-pushed
the
fix/ci-docker-rate-limit
branch
from
d3a71fc to
e56acac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testdepends onbuild, which uses Docker to pullnode:24-bullseyeand runyarn buildyarn buildstep, so the Docker pull is redundanttoomanyrequests) — example failed runwjdp/htmltestdirectly against the existingbuild/directory insteadRelated Issues
Unblocks #1351