Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Account for go mod download in go1.17 not updating go.sum#50

Merged
jpkrohling merged 1 commit intoopen-telemetry:mainfrom
pmalek-sumo:fix-1.17-go-mod-download-all
Jun 24, 2021
Merged

Account for go mod download in go1.17 not updating go.sum#50
jpkrohling merged 1 commit intoopen-telemetry:mainfrom
pmalek-sumo:fix-1.17-go-mod-download-all

Conversation

@pmalek-sumo
Copy link
Copy Markdown
Contributor

Because the behaviour of go mod download changes in go1.17 we need to account for that. For previous versions this will result in the same behaviour.

go mod download
When go mod download is invoked without arguments, it will no longer save sums for downloaded module content to go.sum. It may still make changes to go.mod and go.sum needed to load the build list. This is the same as the behavior in Go 1.15. To save sums for all modules, use go mod download all.

ref: https://tip.golang.org/doc/go1.17

@pmalek-sumo pmalek-sumo requested review from a team, jpkrohling and tigrannajaryan and removed request for a team June 16, 2021 12:19
@fangyi-zhou
Copy link
Copy Markdown
Contributor

fangyi-zhou commented Jun 16, 2021

This seems a better solution than what I did in d6406b0

@jpkrohling
Copy link
Copy Markdown
Member

Sorry, I ended up merging @fangyi-zhou's PR first, which caused a conflict with this. @pmalek-sumo, could you please rebase? I'll merge it right after that and perform a release.

@pmalek-sumo pmalek-sumo force-pushed the fix-1.17-go-mod-download-all branch from 0f66203 to b9a9746 Compare June 24, 2021 09:38
@pmalek-sumo
Copy link
Copy Markdown
Contributor Author

@jpkrohling Done, please recheck.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants