This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Account for go mod download in go1.17 not updating go.sum#50
Merged
jpkrohling merged 1 commit intoopen-telemetry:mainfrom Jun 24, 2021
Merged
Conversation
Contributor
|
This seems a better solution than what I did in d6406b0 |
Member
|
Sorry, I ended up merging @fangyi-zhou's PR first, which caused a conflict with this. @pmalek-sumo, could you please rebase? I'll merge it right after that and perform a release. |
0f66203 to
b9a9746
Compare
Contributor
Author
|
@jpkrohling Done, please recheck. |
jpkrohling
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the behaviour of
go mod downloadchanges in go1.17 we need to account for that. For previous versions this will result in the same behaviour.ref: https://tip.golang.org/doc/go1.17