Update to collector v0.29.0

[himanshu007-creator]

Resolves #52

[jpkrohling]

Didn't it require a change to address open-telemetry/opentelemetry-collector#3268 ?

[himanshu007-creator]

Didn't it require a change to address open-telemetry/opentelemetry-collector#3268 ?

sorry, can you explain?!

[jpkrohling]

The builder uses API from the collector, including the one that got changed by the PR open-telemetry/opentelemetry-collector#3268 . The tests are indeed failing, as the builder needs to use the new API:

2021-06-25T12:57:03.006Z	ERROR	cmd/root.go:91	failed to run	{"error": "failed to compile the OpenTelemetry Collector distribution: exit status 2. Output: \"# github.com/open-telemetry/opentelemetry-collector-builder/test/nocore\\n./main.go:40:26: undefined: service.AppSettings\\n\""}
github.com/go-logr/zapr.(*zapLogger).Error
	/home/runner/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132
github.com/open-telemetry/opentelemetry-collector-builder/cmd.Execute
	/home/runner/work/opentelemetry-collector-builder/opentelemetry-collector-builder/cmd/root.go:91
main.main
	/home/runner/work/opentelemetry-collector-builder/opentelemetry-collector-builder/main.go:25
runtime.main
	/opt/hostedtoolcache/go/1.16.5/x64/src/runtime/proc.go:225
failed to compile the OpenTelemetry Collector distribution: exit status 2. Output: "# github.com/open-telemetry/opentelemetry-collector-builder/test/nocore\n./main.go:40:26: undefined: service.AppSettings\n"
exit status 1

I wonder how you were able to run the builder locally.

[jpkrohling]

By the way, here's the place to fix it:

opentelemetry-collector-builder/internal/scaffold/main.go

Line 56 in a468961

app, err := service.New(service.AppSettings{BuildInfo: info, Factories: factories})

[himanshu007-creator]

The builder uses API from the collector, including the one that got changed by the PR open-telemetry/opentelemetry-collector#3268 . The tests are indeed failing, as the builder needs to use the new API:

2021-06-25T12:57:03.006Z	ERROR	cmd/root.go:91	failed to run	{"error": "failed to compile the OpenTelemetry Collector distribution: exit status 2. Output: \"# github.com/open-telemetry/opentelemetry-collector-builder/test/nocore\\n./main.go:40:26: undefined: service.AppSettings\\n\""}
github.com/go-logr/zapr.(*zapLogger).Error
	/home/runner/go/pkg/mod/github.com/go-logr/zapr@v0.2.0/zapr.go:132
github.com/open-telemetry/opentelemetry-collector-builder/cmd.Execute
	/home/runner/work/opentelemetry-collector-builder/opentelemetry-collector-builder/cmd/root.go:91
main.main
	/home/runner/work/opentelemetry-collector-builder/opentelemetry-collector-builder/main.go:25
runtime.main
	/opt/hostedtoolcache/go/1.16.5/x64/src/runtime/proc.go:225
failed to compile the OpenTelemetry Collector distribution: exit status 2. Output: "# github.com/open-telemetry/opentelemetry-collector-builder/test/nocore\n./main.go:40:26: undefined: service.AppSettings\n"
exit status 1

I wonder how you were able to run the builder locally.

I didnt😬, just changed the code here.

[jpkrohling]

Thank you for this PR!