[redisreceiver] Fix incorrect metric types and units in Redis receiver metadata

[shmsr]

Component(s)

receiver/redis

What happened?

Description

The Redis receiver has several bugs in its metadata.yaml file where metrics are incorrectly classified as sum when they should be gauge, and some units are incorrect for offset values.

Steps to Reproduce

NA

Expected Result

Several metrics representing current state are incorrectly defined as sum metrics:

• redis.clients.connected
• redis.clients.blocked
• redis.slaves.connected
• redis.rdb.changes_since_last_save
• redis.role

A couple of metrics needs fixes in its unit field:

*offset metrics are marked as unit: "By" i.e., redis.replication.backlog_first_byte_offset and redis.replication.offset

Ref: https://redis.io/docs/latest/commands/info/ to now about the metrics

Actual Result

• metrics should be marked as gauge and not sum for the aforementioned metrics
• redis.replication.backlog_first_byte_offset and redis.replication.offset should have unit: 1?

Collector version

v0.128.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

Log output

Additional context

No response

[shmsr]

I'd like to take this up

[github-actions]

Pinging code owners:

• receiver/redis: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[shmsr]

Since Redis receiver has stability: beta: [metrics], and as per https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/scraping-receivers.md, do I have to put something like a deprecated notice?

redis.clients.connected:
enabled: true
description: "[DEPRECATED] Number of client connections. Metric type will change from sum to gauge in v0.XX.0"
sum:
monotonic: false

And then make the actual fix in the next release? How does it work?

Or should I go ahead and fix it as it is in beta right now?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/redisreceiver: @dmitryax @hughesjj

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.