[chore] Fix header levels of makefile guidelines in CONTRIBUTING.md#29453
Merged
codeboten merged 2 commits intoopen-telemetry:mainfrom Nov 22, 2023
Merged
[chore] Fix header levels of makefile guidelines in CONTRIBUTING.md#29453codeboten merged 2 commits intoopen-telemetry:mainfrom
codeboten merged 2 commits intoopen-telemetry:mainfrom
Conversation
Upon review, the Makefile Guidelines section (and its own subsections) is under the Becoming a Code Owner section. This is not correct, so this moves the Makefile Guidelines section to be directly underneath the top level Contributing header.
codeboten
approved these changes
Nov 22, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…pen-telemetry#29453) **Documentation:** <Describe the documentation added.> Upon review, the `Makefile Guidelines` section (and its own subsections) is under the `Becoming a Code Owner` section. This is not correct, so this change moves the `Makefile Guidelines` section to be directly underneath the top level `Contributing` header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation:
Upon review, the
Makefile Guidelinessection (and its own subsections) is under theBecoming a Code Ownersection. This is not correct, so this change moves theMakefile Guidelinessection to be directly underneath the top levelContributingheader.