Introduce sampling package as reference implementation for OTEP 235 by jmacd · Pull Request #29720 · open-telemetry/opentelemetry-collector-contrib

jmacd · 2023-12-08T22:27:59Z

Description: This is the pkg/sampling portion of of #24811.

Link to tracking Issue:
#29738
open-telemetry/opentelemetry-specification#1413

Testing: Complete.

Documentation: New README added.

codeboten

Thanks for splitting up the PR @jmacd, this is much easier to review. Will add some more comments, just some quick things to fix noted so far

processor/probabilisticsamplerprocessor/go.mod

.github/CODEOWNERS

…tor-contrib into jmacd/pkgsampl

jmacd · 2023-12-11T17:15:28Z

@kentquirk please confirm willingness to co-own this code :-)

…tor-contrib into jmacd/pkgsampl

jpkrohling · 2023-12-12T10:26:34Z

I'd like to review this, but I'm unable to do so this year. I'm back on Jan 15, please ping me again on Jan 18 if I haven't reviewed this here by then.

pkg/sampling/doc.go

pkg/sampling/common.go

pkg/sampling/encoding_test.go

pkg/sampling/oteltracestate.go

codeboten

I haven't looked at the other PR that utilizes this package, but i'm curious if the surface area being exposed in this package could be reduced

pkg/sampling/oteltracestate.go

…aders

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

kentquirk

Leaving a bunch more comments since it's changing out from under me while I try to make them.

pkg/sampling/oteltracestate.go

pkg/sampling/doc.go

pkg/sampling/encoding_test.go

pkg/sampling/threshold.go

pkg/sampling/randomness.go

pkg/sampling/encoding_test.go

pkg/sampling/oteltracestate_test.go

Co-authored-by: Kent Quirk <kentquirk@gmail.com>

jmacd · 2024-01-26T14:52:49Z

@kentquirk thanks! I'm going to rest on this for a while, with the couple of unresolved comments you left standing. I'm willing to come back to the error handling in Serialize later if possible, but would like to resolve the HasField() and Field() accessor questions.

Other reviewers, lots of progress has been made, and it's very close.

…tor-contrib into jmacd/pkgsampl

pkg/sampling/doc.go

codeboten · 2024-01-30T19:09:40Z

@kentquirk @atoulme please review and approve if your comments have been addressed

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

…ctor-contrib into jmacd/pkgsampl

kentquirk

I'm now happy with this (and reiterate my agreement to be a codeowner).

jmacd · 2024-01-31T00:51:36Z

FYI OTEP 235 merged. I think this is ready to merge, too. 😀

atoulme

LGTM

…pen-telemetry#29720) **Description:** This is the `pkg/sampling` portion of of open-telemetry#24811. **Link to tracking Issue:** open-telemetry#29738 open-telemetry/opentelemetry-specification#1413 **Testing:** Complete. **Documentation:** New README added. --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Kent Quirk <kentquirk@gmail.com>

jmacd added 2 commits December 8, 2023 14:26

Add comments, README, metadata.yaml relative to open-telemetry#24811

2741a32

add new package

91f6909

jmacd marked this pull request as ready for review December 8, 2023 22:31

jmacd requested review from a team and dmitryax December 8, 2023 22:31

github-actions bot assigned Aneurysm9 Dec 8, 2023

jmacd added 2 commits December 8, 2023 14:34

crosslink

2834241

doc

12530ec

jmacd requested a review from jpkrohling as a code owner December 8, 2023 22:34

github-actions bot added the processor/probabilisticsampler Probabilistic Sampler processor label Dec 8, 2023

more place

4a83262

codeboten reviewed Dec 8, 2023

View reviewed changes

processor/probabilisticsamplerprocessor/go.mod Outdated Show resolved Hide resolved

.github/CODEOWNERS Outdated Show resolved Hide resolved

jmacd added 4 commits December 11, 2023 08:44

Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…

b4c9b78

…tor-contrib into jmacd/pkgsampl

changelog

53ac105

no change here

910beac

more linty

5997a19

jmacd added 6 commits December 11, 2023 10:15

lintier than thou

2e9ddeb

Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…

1909040

…tor-contrib into jmacd/pkgsampl

fix that

3de01cc

hmm

1307b1d

delint

28ea1e4

do what it says

5661ced

atoulme reviewed Dec 15, 2023

View reviewed changes

pkg/sampling/doc.go Outdated Show resolved Hide resolved

codeboten reviewed Dec 15, 2023

View reviewed changes

pkg/sampling/oteltracestate.go Outdated Show resolved Hide resolved

jmacd added 3 commits December 19, 2023 11:07

Comment on why must() and mustNot() are here

95ac7f0

more comments

47ddb07

more comment

0042984

jmacd and others added 7 commits January 25, 2024 12:27

improve probability testing; add comments to the example tests for re…

dbb04d2

…aders

more testing

8fc6004

doc comments

554c351

Add higher-level example in doc comment

c8c196d

test for no-error, fix test as called out by jpk

e294124

Apply suggestions from code review

f48df39

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

lcAlphanum

637a787

kentquirk reviewed Jan 26, 2024

View reviewed changes

Apply suggestions from code review

f4e4d7a

Co-authored-by: Kent Quirk <kentquirk@gmail.com>

jmacd added 2 commits January 26, 2024 06:53

Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…

c7c796b

…tor-contrib into jmacd/pkgsampl

tidy

c565f3c

jpkrohling approved these changes Jan 29, 2024

View reviewed changes

pkg/sampling/doc.go Outdated Show resolved Hide resolved

jmacd and others added 3 commits January 30, 2024 11:41

Update pkg/sampling/doc.go

231c3e4

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

Remove most of the Has methods

896f4b8

Merge branch 'jmacd/pkgsampl' of github.com:jmacd/opentelemetry-colle…

ba64e94

…ctor-contrib into jmacd/pkgsampl

kentquirk approved these changes Jan 30, 2024

View reviewed changes

update/tidy

a3844ca

atoulme approved these changes Jan 31, 2024

View reviewed changes

jpkrohling merged commit 2cebf1f into open-telemetry:main Jan 31, 2024

github-actions bot added this to the next release milestone Jan 31, 2024

jmacd deleted the jmacd/pkgsampl branch January 31, 2024 17:29

jpkrohling mentioned this pull request Feb 14, 2024

New component: pkg/sampling #29738

Closed

2 tasks

jmacd mentioned this pull request Feb 27, 2024

Probability Samplers based on W3C Trace Context Level 2 open-telemetry/opentelemetry-specification#3910

Closed

5 tasks

This was referenced Mar 6, 2024

Add OpenTelemetry sampling conventions open-telemetry/semantic-conventions#793

Closed

Update Trace specification to use W3C Trace Context Level 2; add Random flag open-telemetry/opentelemetry-specification#3924

Closed

Conversation

jmacd commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeboten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmacd commented Dec 11, 2023

Uh oh!

jpkrohling commented Dec 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codeboten left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kentquirk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmacd commented Jan 26, 2024

Uh oh!

Uh oh!

codeboten commented Jan 30, 2024

Uh oh!

kentquirk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmacd commented Jan 31, 2024

Uh oh!

atoulme left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmacd commented Dec 8, 2023 •

edited

Loading

kentquirk left a comment •

edited

Loading