Fix: Ensure publisher does not include token in exported data#35154
Merged
mx-psi merged 1 commit intoopen-telemetry:mainfrom Sep 12, 2024
Merged
Fix: Ensure publisher does not include token in exported data#35154mx-psi merged 1 commit intoopen-telemetry:mainfrom
mx-psi merged 1 commit intoopen-telemetry:mainfrom
Conversation
This will ensure that tokens are not leaked through the event API
MovieStoreGuy
force-pushed
the
msg/fix-token-removal
branch
from
ff7a4ad to
36724da
Compare
mx-psi
approved these changes
Sep 12, 2024
crobert-1
approved these changes
Sep 12, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…elemetry#35154) **Description:** This will ensure that tokens are not leaked through the event API. **Link to tracking Issue:** **Testing:** Updated the tests to ensure that the token isn't include in the final data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This will ensure that tokens are not leaked through the event API.
Link to tracking Issue:
Testing:
Updated the tests to ensure that the token isn't include in the final data.